-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding log sort flag to disable stable sort and get better memory performance in some situations #17354
Conversation
…rmance in some situations
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
src/main/java/com/google/devtools/build/lib/bazel/SpawnLogModule.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/exec/SpawnLogContext.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
Outdated
Show resolved
Hide resolved
…rmance in some situations
…rmance in some situations
@tjgq Hi, I've updated some files and got 5 failed tests. How can I resolve those failed checks? Thanks! |
Please ignore the failing tests on MacOS for now; they're unrelated to your PR. Someone else is working on fixing them. |
@YuanHao97 at least one of the failures seems to be caused by your PR:
In addition, please do the following before this PR can be merged:
I think the other broken tests have now been fixed, so you should get a cleaner result when you push again. |
@tjgq Sorry, I got some compiling problems before push, so it's difficult to do verification. |
To get Intellij support for Bazel builds, see https://ij.bazel.build/. I think this looks good now. Could you please sign the CLA (#17354 (comment)) so I can start the import process? |
@tjgq I've already siged cla. Please take a look at the check list. |
My bad, sorry. I'll start the import process. |
@bazel-io flag |
@bazel-io fork 6.1.0 |
This may improve performance when the execution log gets very large. The default is still to sort, so this is a backwards-compatible change. Closes #17354. Closes #17111. PiperOrigin-RevId: 509822315 Change-Id: If948ec4a933389b6f8405985813dd76c549c445c Co-authored-by: Hao Yuan <[email protected]>
fix #17111
add log sorting flag to disable stable sort and get better memory performance in some situations.
command line flag: --execution_log_sort
possible values:
true : use stable sort as before when writing logs to a file. See com.google.devtools.build.lib.bazel.execlog.StableSort#stableSort
false : do not sort logs. Write directly from input stream to output stream.